Avoid crash when invalid URI is passed to test file write #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryskool
approved these changes
Jun 25, 2025
jonbartels
reviewed
Jun 25, 2025
tonygermano
approved these changes
Jun 27, 2025
pacmano1
approved these changes
Jul 1, 2025
kpalang
approved these changes
Jul 1, 2025
jonbartels
approved these changes
Jul 1, 2025
gibson9583
approved these changes
Jul 1, 2025
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
tonygermano
force-pushed
the
fix/crash-on-filewrite
branch
from
b6f533b to
7178846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124 / original #4963.
Updates server to provide a normal failure when a URI can't be parsed.
Implementation notes: